Skip to content

Allow non-200 HTTP status codes #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Allow non-200 HTTP status codes #419

merged 3 commits into from
Jul 19, 2022

Conversation

sungam3r
Copy link
Member

@sungam3r sungam3r commented Jul 18, 2022

See https://github.com/graphql/graphql-over-http/blob/main/spec/GraphQLOverHTTP.md#status-codes . Spec allow to return 400 i ncase of validation errors. GraphQL.NET / server support it.

@sungam3r sungam3r requested a review from rose-a July 18, 2022 12:51
@sungam3r sungam3r self-assigned this Jul 18, 2022
@sungam3r
Copy link
Member Author

@rose-a Please review. This feature blocks me from migrating some of our services to GraphQL.NET v5 since all validation errors return 400 instead of 200 now.

@sungam3r
Copy link
Member Author

@rose-a If you fine with proposed changes I would like to publish fresh packages ASAP.

@sungam3r sungam3r added the enhancement New feature or request label Jul 19, 2022
@rose-a rose-a merged commit ac2043a into master Jul 19, 2022
@rose-a rose-a deleted the badrequest branch July 19, 2022 22:36
@sungam3r
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants