DjangoModelFormMutation getting "an invalid keyword argument for Mutation" error instead of model form errors

[Aljabri-Salman]

When using DjangoModelFormMutation and getting a modelform error the mutation shows an invalid keyword argument for Mutation as shown below. I am supposed to get errors for the field name showing "This name has already been registered." However I am getting graphql.error.located_error.GraphQLLocatedError: 'name' is an invalid keyword argument for CategoryMutation

# model
class Category(models.Model):
    name = models.CharField(max_length=10, unique=True,
                 error_messages={'unique':"This name has already been registered."})

    def __str__(self):
        return self.name

#model form
class CategoryForm(ModelForm):
    class Meta:
        model = Category
        exclude = []

# create category mutation
class CategoryMutation(DjangoModelFormMutation):
    category = graphene.Field(CategoryType)
    class Meta:
        form_class = CategoryForm

mutation:

mutation {
  categoryCreate(input: {name: "spices"}) {
    errors {
      field,
      messages
    }
  }
}

results when the name is not unique:

{
  "errors": [
    {
      "message": "'name' is an invalid keyword argument for CategoryMutation",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "categoryCreate"
      ]
    }
  ],
  "data": {
    "categoryCreate": null
  }
}

[ajatprabha]

There should be two things that should be changed IMO

1. An assertion that return_field_name is set in Meta options to match a field name in mutation class
   

   graphene-django/graphene_django/forms/mutation.py

   Lines 165 to 169 in b84f61a

   	@classmethod
   	def perform_mutate(cls, form, info):
   	obj = form.save()
   	kwargs = {cls._meta.return_field_name: obj}
   	return cls(errors=[], **kwargs)

2. form.data should be handled differently or should be removed altogether and the length of errors should be used to determine success/failure
   

   graphene-django/graphene_django/forms/mutation.py

   Lines 45 to 50 in b84f61a

   	if form.is_valid():
   	return cls.perform_mutate(form, info)
   	else:
   	errors = ErrorType.from_errors(form.errors)
   	return cls(errors=errors, **form.data)

[Aljabri-Salman]

@ajatprabha you are right removing the **form.data fixed the problem. But I wonder why it is passed as kwargs? is it intended to return the invalid data back to the client ? I don't see the point of it.

[ajatprabha]

Yes, it's for returning back the invalid data, however, it's not dynamic enough to work properly right now.

[jkimbo]

This issue should be fixed in #915 Sorry for the inconvenience

[jkimbo]

Just released v2.9.1 that should fix this: https://github.com/graphql-python/graphene-django/releases/tag/v2.9.1