Skip to content

Enforce NonNull for returned related Sets and their content #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2019
Merged

Enforce NonNull for returned related Sets and their content #690

merged 3 commits into from
Jun 25, 2019

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Jun 25, 2019 •
edited
Loading

As discussed in #44 : when you retrieve the related Set of an object,

  1. You never get None : when no related items are returned, you get an empty Set.
  2. You never, ever get a Set of None.
    This PR enforces the fact that the Set is NonNull, and so is each object in the Set.

(PR recreated from #681 by @dperetti)

@jkimbo jkimbo mentioned this pull request Jun 25, 2019
Closed
@dperetti
Copy link

For reference, the discussion was actually #448

@jkimbo jkimbo merged commit 54cc6a4 into master Jun 25, 2019
@jkimbo jkimbo deleted the dperetti-master branch June 25, 2019 15:30
@jkimbo jkimbo mentioned this pull request Jul 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phalt phalt phalt approved these changes

@mvanlonden mvanlonden mvanlonden approved these changes

@danpalmer danpalmer Awaiting requested review from danpalmer

@dopeboy dopeboy Awaiting requested review from dopeboy

@zbyte64 zbyte64 Awaiting requested review from zbyte64

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkimbo @dperetti @phalt @mvanlonden