Adds variables arg to GraphQLTestCase.query #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkimbo
requested changes
Jul 28, 2019
There was a problem hiding this comment.
This looks like a great addition thanks @tlambert03 ! Added some comments that should be addressed before merging.
|
Would be good to get this merged in. Seems odd that input_type is an arg but variables isn't. |
mvanlonden
approved these changes
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking for a way to test queries with variables, and formatting the query string directly was a little messy, and I didn't need anything as complex as a custom
input_type. If you would prefer I accomplish this by subclassingGraphQLTestCase, I understand... but here's a PR just in case you find it useful. Also added an example to the docs.