Skip to content

added support for partial updates in serializers #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

dan-klasson
Copy link
Contributor

@dan-klasson dan-klasson commented Aug 3, 2019

Related to this issue: #726

Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-klasson but can you add some tests to verify that the change works?

@stale
Copy link

stale bot commented Oct 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 2, 2019
@stale stale bot closed this Oct 9, 2019
@jkimbo
Copy link
Member

jkimbo commented Oct 18, 2019

@dan-klasson are you able to add those tests?

@jkimbo jkimbo reopened this Oct 18, 2019
@stale stale bot removed the wontfix label Oct 18, 2019
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test

@jkimbo jkimbo merged commit 7940a7b into graphql-python:master Dec 27, 2019
@thomaszdxsn
Copy link

It not work on one serializer support both create/update.

because create often need all fields required. and partial update don't need, so I think should make two InputType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants