-
Notifications
You must be signed in to change notification settings - Fork 766
Only warn if a field doesn't exist on the Django model #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also don't warn if the field name matches a custom field.
I understand not having a warning or error for custom fields. But I am less clear on the reasoning for not raising an exception for when there is no attribute on the model. Might be useful to state the consequence of each warning in the warning. For instance, "Field name .* exists on Django model .* but it's not a model field" - does this mean my fields wont be read? If there isn't a real consequence then I would drop the warning and embrace the feature. |
@zbyte64 I've expanded the error messages to be more descriptive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
A more detailed explanation can be found on the release notes of the v2.8.0 and v.2.8.1 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.0 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.1 And the PRs where the changes were introduced: - graphql-python/graphene-django#842 - graphql-python/graphene-django#862
A more detailed explanation can be found on the release notes of the v2.8.0 and v.2.8.1 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.0 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.1 And the PRs where the changes were introduced: - graphql-python/graphene-django#842 - graphql-python/graphene-django#862
A more detailed explanation can be found on the release notes of the v2.8.0 and v.2.8.1 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.0 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.1 And the PRs where the changes were introduced: - graphql-python/graphene-django#842 - graphql-python/graphene-django#862
A more detailed explanation can be found on the release notes of the v2.8.0 and v.2.8.1 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.0 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.1 And the PRs where the changes were introduced: - graphql-python/graphene-django#842 - graphql-python/graphene-django#862
A more detailed explanation can be found on the release notes of the v2.8.0 and v.2.8.1 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.0 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.1 And the PRs where the changes were introduced: - graphql-python/graphene-django#842 - graphql-python/graphene-django#862
A more detailed explanation can be found on the release notes of the v2.8.0 and v.2.8.1 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.0 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.1 And the PRs where the changes were introduced: - graphql-python/graphene-django#842 - graphql-python/graphene-django#862
A more detailed explanation can be found on the release notes of the v2.8.0 and v.2.8.1 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.0 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.1 And the PRs where the changes were introduced: - graphql-python/graphene-django#842 - graphql-python/graphene-django#862
A more detailed explanation can be found on the release notes of the v2.8.0 and v.2.8.1 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.0 - https://github.com/graphql-python/graphene-django/releases/tag/v2.8.1 And the PRs where the changes were introduced: - graphql-python/graphene-django#842 - graphql-python/graphene-django#862
Also don't warn if the field name matches a custom field.
Resolves issues from #842