features: ConnectionField customization, LazyReferences, better field descriptions #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…field descriptions.
…filters on Connection fields. • Subclassing or replacing automatically attached/converted MongoengineConnectionField is possible by specifying `connection_field_class` in the ObjectType meta. • A new API for specifying a callable that can return custom filters or a queryset when generating a connection iterable: `get_queryset`. • Refactors MongoengineConnectionField to use existing graphene connection functions instead of reinventing list slicing. • Refactors MongoengineConnectionField to do object lookup as an instance method instead of doing wacky things with the connection class methods. Should make subclassing get_queryset and default_resolver much more useful and intuitive.
|
Also happy to split the PR into related subcomponents and submit individually, if preferred. |
Pull Request Test Coverage Report for Build 216
💛 - Coveralls |
…nnection resolver with more expected get_node convention.
|
Thanks for the PR 👍 |
|
@zrlay Looks good to me, merged. |
zrlay
added a commit
to zrlay/graphene-mongo
that referenced
this pull request
Feb 13, 2019
Merge pull request graphql-python#69 from zrlay/master
arunsureshkumar
pushed a commit
to arunsureshkumar/graphene-mongo
that referenced
this pull request
Nov 2, 2020
features: ConnectionField customization, LazyReferences, better field descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for a handful of features we've been enjoying in production.
Some are minimal changes like better field descriptions based on common mongoengine field attributes like
help_textor docstrings, others are potentially breaking such as refactoring MongoengineConnectionField to lean less on class methods in favor of more intuitive instance methods.Would very much like feedback and discussion!