[graphiql] v4.0.1 gives tonz of import errors when using php

[simPod]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

I'm using yarn v4 with PnP

graphiql v4.0.0 is ok

graphiql v4.0.1+ gives following errors

Could not resolve "graphql"

    ../.yarn/__virtual__/@graphiql-react-virtual-dad9d23c78/5/.yarn/berry/cache/@graphiql-react-npm-0.31.0-98df7f12cf-10c0.zip/node_modules/@graphiql/react/dist/explorer/components/doc-explorer.js:3:23:
      3 │ import { isType } from "graphql";
        ╵                        ~~~~~~~~~

  The Yarn Plug'n'Play manifest says this package has a peer dependency on "graphql", but the
  package "graphql" has not been installed:

    ../.pnp.cjs:2360:22:

Expected Behavior

No errors.

Steps To Reproduce

1. Use Yarn with PnP
2. import gql
3. compile

import { createGraphiQLFetcher } from '@graphiql/toolkit';
import { GraphiQL } from 'graphiql';

I have only such 2 imports -> gives 36 dependency errors

Environment

• GraphiQL Version: 4.0.1
• OS: macos
• Browser: n/a
• Bundler: vite
• react Version: 19
• graphql Version: 16

Anything else?

No response

[dimaMachina]

please provide runnable reproduction, so it could be fixed quickly

[dimaMachina]

Also, do you have graphql dependency installed? It has a required peerDependency

graphiql/packages/graphiql/package.json

Lines 54 to 55 in 2e14da2

	"peerDependencies": {
	"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0",

[simPod]

yes, graphql is installed

…

On Sun, May 4, 2025, 23:19 Dimitri POSTOLOV ***@***.***> wrote: *dimaMachina* left a comment (graphql/graphiql#3919) <#3919 (comment)> Also, do you have graphql dependency installed? It's has a required peerDependency https://github.com/graphql/graphiql/blob/2e14da29fc7c25bf14b24b66bc2bc088f868458f/packages/graphiql/package.json#L54-L55 — Reply to this email directly, view it on GitHub <#3919 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQAJLEHNBH5KNQ25X32W324Z75RAVCNFSM6AAAAAB4NFJH5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBZGQ2DGNRUHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[dimaMachina]

ok, please provide a reproduction, so I could take a look at your issue

[simPod]

Here https://github.com/simPod/graphiql-repro/actions/runs/14837669778/job/41652591875

…

On Mon, May 5, 2025 at 1:46 AM Dimitri POSTOLOV ***@***.***> wrote: *dimaMachina* left a comment (graphql/graphiql#3919) <#3919 (comment)> ok, please provide a reproduction, so I could take a look at your issue — Reply to this email directly, view it on GitHub <#3919 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACQAJPUXEZ5WO4RJ5I5SVT242RD5AVCNFSM6AAAAAB4NFJH5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBZGUYDCOJSGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[dimaMachina]

Here
simPod/graphiql-repro/actions/runs/14837669778/job/41652591875
…

Thanks, interesting, setting nodeLinker: node-modules in .yarnrc.yml doesn't throw an error

[simPod]

Yup, that's because it's softly resolved from node_modules and the import is satisfied even though the library does not explicitly declare it but some other irrelevant library does.

[dimaMachina]

It seems that patching GraphiQL's package.json files with yarn patch doesn't install new dependencies, so I'm unable to help you find a fix

[simPod]

The hotfix is

packageExtensions:
  "@graphiql/react@*":
    dependencies:
      "graphql": "*"
  "@graphiql/toolkit@*":
    dependencies:
      "graphql": "*"

I think the root issue is also this yarnpkg/yarn#7014