Skip to content

Parse extend schema correctly when root operations list is absent #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Parse extend schema correctly when root operations list is absent #3670

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4d6d964
Add tests for parsing schema extensions
trevor-scheer Jul 31, 2024
3ff3379
Add a failing test
trevor-scheer Jul 31, 2024
36afde3
Merge branch 'main' into patch-2
trevor-scheer Sep 30, 2024
6938c31
Fix parser and update tests
trevor-scheer Sep 30, 2024
e66383c
changeset
trevor-scheer Sep 30, 2024
4de5ad8
Merge branch 'main' into patch-2
trevor-scheer Oct 3, 2024
8647065
Merge branch 'main' into patch-2
trevor-scheer Nov 26, 2024
b0942f9
Update .changeset/afraid-oranges-clean.md
trevor-scheer Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update .changeset/afraid-oranges-clean.md 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
  • Loading branch information
@trevor-scheer @TallTed
trevor-scheer and TallTed authored Dec 2, 2024
commit b0942f94309d0ba3e391ebd064ebc8f1a0581838
2 changes: 1 addition & 1 deletion .changeset/afraid-oranges-clean.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ fix: Correctly parse schema extensions with no root operations

Previously, the parser gave schema extensions the same treatment as schema definitions. The requirements are slightly different, however, since a schema extension does not require a list of root operations according to the spec: https://spec.graphql.org/draft/#sec-Schema-Extension.

The rule for parsing a schema extension is now distinct from schema definition, allowing the root operations list to be omitted.
The rule for parsing a schema extension is now distinct from that for a schema definition, allowing the root operations list to be omitted.
Loading