fix(graphql-language-service): return null
instead of empty contents
array when hover results are empty
#3913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently submitted a (rejected) PR in Neovim because LSPs including
graphiql
andvtsls
are returning empty hover `contents` arrays when there is no result, which is almost always the case forgraphiql
since it would only ever be expected to produce hover results for embedded#graphql
query strings.The effect of this is that
graphiql
is showing up in the Neovim LSP hover summary every time a hover request is made, even when there are no results, at locations in the code where results fromgraphiql
would never be expected:Since the LSP spec allows a hover request to return `null`, this change is to align with the LSP spec to return an empty result (
null
) when there are no results instead of an emptycontents
array.Thank you for the GraphiQL language server :)
Related PR: yioneko/vtsls#248