Skip to content

Fragment Arguments Reference Implementation #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fragment Arguments Reference Implementation #3835

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b1ae03
Fragment Arguments: Only Syntax Changes
mjmahone Feb 9, 2023
e9fbda2
RFC: Fragment Arguments
mjmahone Jan 19, 2023
bfd80a6
Add flag for parser
mjmahone Feb 9, 2023
7fe0733
Split PRs, no functional changes
mjmahone Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add flag for parser
  • Loading branch information
@mjmahone
mjmahone committed Feb 9, 2023
commit bfd80a6dcbcf974c18f757df848d854c43b8a9db
2 changes: 1 addition & 1 deletion src/__testUtils__/kitchenSinkQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ query queryName($foo: ComplexType, $site: Site = MOBILE) @onQuery {
...frag @onFragmentSpread
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated?


field3!
field4?
requiredField5: field5!
Expand Down
2 changes: 1 addition & 1 deletion src/execution/__tests__/variables-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ function executeQuery(
query: string,
variableValues?: { [variable: string]: unknown },
) {
const document = parse(query);
const document = parse(query, { experimentalFragmentArguments: true });
return executeSync({ schema, document, variableValues });
}

Expand Down
23 changes: 13 additions & 10 deletions src/utilities/__tests__/TypeInfo-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,17 +519,20 @@ describe('visitWithTypeInfo', () => {
it('supports traversals of fragment arguments', () => {
const typeInfo = new TypeInfo(testSchema);

const ast = parse(`
query {
...Foo(x: 4)
}
const ast = parse(
`
query {
...Foo(x: 4)
}

fragment Foo(
$x: ID!
) on QueryRoot {
human(id: $x) { name }
}
`);
fragment Foo(
$x: ID!
) on QueryRoot {
human(id: $x) { name }
}
`,
{ experimentalFragmentArguments: true },
);

const visited: Array<any> = [];
visit(
Expand Down