Skip to content

tests: remove empty strings in string literals #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2023
Merged

tests: remove empty strings in string literals #3970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,14 @@ module.exports = {
'no-restricted-globals': 'off',
'no-restricted-imports': 'off',
'no-restricted-properties': 'off',
'no-restricted-syntax': 'off',
'no-restricted-syntax': [
'error',
{
selector: 'TemplateElement[value.raw=/ \\n/]',
message:
'String literals should not contain trailing spaces. If needed for tests please disable locally using eslint comment',
},
],
'no-return-assign': 'error',
'no-return-await': 'error',
'no-script-url': 'error',
Expand Down
2 changes: 1 addition & 1 deletion src/__testUtils__/kitchenSinkQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ query queryName($foo: ComplexType, $site: Site = MOBILE) @onQuery {
...frag @onFragmentSpread
}
}

field3!
field4?
requiredField5: field5!
Expand Down
2 changes: 1 addition & 1 deletion src/execution/__tests__/defer-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2025,7 +2025,7 @@ describe('Execute: defer directive', () => {
hero {
friends {
nonNullName
...NameFragment @defer
...NameFragment @defer
}
}
}
Expand Down
70 changes: 35 additions & 35 deletions src/execution/__tests__/stream-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ describe('Execute: stream directive', () => {
});
it('Can stream a field that returns a list of promises', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 2) {
name
id
Expand Down Expand Up @@ -360,7 +360,7 @@ describe('Execute: stream directive', () => {
});
it('Can stream in correct order with lists of promises', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 0) {
name
id
Expand Down Expand Up @@ -410,7 +410,7 @@ describe('Execute: stream directive', () => {
});
it('Can stream a field that returns a list with nested promises', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 2) {
name
id
Expand Down Expand Up @@ -460,7 +460,7 @@ describe('Execute: stream directive', () => {
});
it('Handles rejections in a field that returns a list of promises before initialCount is reached', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 2) {
name
id
Expand Down Expand Up @@ -505,7 +505,7 @@ describe('Execute: stream directive', () => {
});
it('Handles rejections in a field that returns a list of promises after initialCount is reached', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 1) {
name
id
Expand Down Expand Up @@ -559,7 +559,7 @@ describe('Execute: stream directive', () => {
});
it('Can stream a field that returns an async iterable', async () => {
const document = parse(`
query {
query {
friendList @stream {
name
id
Expand Down Expand Up @@ -616,7 +616,7 @@ describe('Execute: stream directive', () => {
});
it('Can stream a field that returns an async iterable, using a non-zero initialCount', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 2) {
name
id
Expand Down Expand Up @@ -658,7 +658,7 @@ describe('Execute: stream directive', () => {
});
it('Negative values of initialCount throw field errors on a field that returns an async iterable', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: -2) {
name
id
Expand All @@ -684,7 +684,7 @@ describe('Execute: stream directive', () => {
});
it('Can handle concurrent calls to .next() without waiting', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 2) {
name
id
Expand Down Expand Up @@ -736,7 +736,7 @@ describe('Execute: stream directive', () => {
});
it('Handles error thrown in async iterable before initialCount is reached', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 2) {
name
id
Expand Down Expand Up @@ -764,7 +764,7 @@ describe('Execute: stream directive', () => {
});
it('Handles error thrown in async iterable after initialCount is reached', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 1) {
name
id
Expand Down Expand Up @@ -804,7 +804,7 @@ describe('Execute: stream directive', () => {
});
it('Handles null returned in non-null list items after initialCount is reached', async () => {
const document = parse(`
query {
query {
nonNullFriendList @stream(initialCount: 1) {
name
}
Expand Down Expand Up @@ -842,7 +842,7 @@ describe('Execute: stream directive', () => {
});
it('Handles null returned in non-null async iterable list items after initialCount is reached', async () => {
const document = parse(`
query {
query {
nonNullFriendList @stream(initialCount: 1) {
name
}
Expand Down Expand Up @@ -889,7 +889,7 @@ describe('Execute: stream directive', () => {
});
it('Handles errors thrown by completeValue after initialCount is reached', async () => {
const document = parse(`
query {
query {
scalarList @stream(initialCount: 1)
}
`);
Expand Down Expand Up @@ -925,7 +925,7 @@ describe('Execute: stream directive', () => {
});
it('Handles async errors thrown by completeValue after initialCount is reached', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 1) {
nonNullName
}
Expand Down Expand Up @@ -978,7 +978,7 @@ describe('Execute: stream directive', () => {
});
it('Handles nested async errors thrown by completeValue after initialCount is reached', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 1) {
nonNullName
}
Expand Down Expand Up @@ -1029,7 +1029,7 @@ describe('Execute: stream directive', () => {
});
it('Handles async errors thrown by completeValue after initialCount is reached for a non-nullable list', async () => {
const document = parse(`
query {
query {
nonNullFriendList @stream(initialCount: 1) {
nonNullName
}
Expand Down Expand Up @@ -1071,7 +1071,7 @@ describe('Execute: stream directive', () => {
});
it('Handles nested async errors thrown by completeValue after initialCount is reached for a non-nullable list', async () => {
const document = parse(`
query {
query {
nonNullFriendList @stream(initialCount: 1) {
nonNullName
}
Expand Down Expand Up @@ -1111,7 +1111,7 @@ describe('Execute: stream directive', () => {
});
it('Handles async errors thrown by completeValue after initialCount is reached from async iterable', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 1) {
nonNullName
}
Expand Down Expand Up @@ -1167,7 +1167,7 @@ describe('Execute: stream directive', () => {
});
it('Handles async errors thrown by completeValue after initialCount is reached from async generator for a non-nullable list', async () => {
const document = parse(`
query {
query {
nonNullFriendList @stream(initialCount: 1) {
nonNullName
}
Expand Down Expand Up @@ -1211,7 +1211,7 @@ describe('Execute: stream directive', () => {
});
it('Handles async errors thrown by completeValue after initialCount is reached from async iterable for a non-nullable list when the async iterable does not provide a return method) ', async () => {
const document = parse(`
query {
query {
nonNullFriendList @stream(initialCount: 1) {
nonNullName
}
Expand Down Expand Up @@ -1279,7 +1279,7 @@ describe('Execute: stream directive', () => {
});
it('Handles async errors thrown by completeValue after initialCount is reached from async iterable for a non-nullable list when the async iterable provides concurrent next/return methods and has a slow return ', async () => {
const document = parse(`
query {
query {
nonNullFriendList @stream(initialCount: 1) {
nonNullName
}
Expand Down Expand Up @@ -1358,7 +1358,7 @@ describe('Execute: stream directive', () => {
});
it('Filters payloads that are nulled', async () => {
const document = parse(`
query {
query {
nestedObject {
nonNullScalarField
nestedFriendList @stream(initialCount: 0) {
Expand Down Expand Up @@ -1391,7 +1391,7 @@ describe('Execute: stream directive', () => {
});
it('Filters payloads that are nulled by a later synchronous error', async () => {
const document = parse(`
query {
query {
nestedObject {
nestedFriendList @stream(initialCount: 0) {
name
Expand Down Expand Up @@ -1424,7 +1424,7 @@ describe('Execute: stream directive', () => {
});
it('Does not filter payloads when null error is in a different path', async () => {
const document = parse(`
query {
query {
otherNestedObject: nestedObject {
... @defer {
scalarField
Expand Down Expand Up @@ -1486,7 +1486,7 @@ describe('Execute: stream directive', () => {
});
it('Filters stream payloads that are nulled in a deferred payload', async () => {
const document = parse(`
query {
query {
nestedObject {
... @defer {
deeperNestedObject {
Expand Down Expand Up @@ -1545,7 +1545,7 @@ describe('Execute: stream directive', () => {
});
it('Filters defer payloads that are nulled in a stream response', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 0) {
nonNullName
... @defer {
Expand Down Expand Up @@ -1624,7 +1624,7 @@ describe('Execute: stream directive', () => {
};

const document = parse(`
query {
query {
nestedObject {
... @defer {
deeperNestedObject {
Expand Down Expand Up @@ -1698,7 +1698,7 @@ describe('Execute: stream directive', () => {
});
it('Handles promises returned by completeValue after initialCount is reached', async () => {
const document = parse(`
query {
query {
friendList @stream(initialCount: 1) {
id
name
Expand Down Expand Up @@ -1815,7 +1815,7 @@ describe('Execute: stream directive', () => {
const { promise: slowFieldPromise, resolve: resolveSlowField } =
promiseWithResolvers();
const document = parse(`
query {
query {
nestedObject {
... DeferFragment @defer
}
Expand Down Expand Up @@ -1918,7 +1918,7 @@ describe('Execute: stream directive', () => {
} = promiseWithResolvers();

const document = parse(`
query {
query {
friendList @stream(initialCount: 1, label:"stream-label") {
...NameFragment @defer(label: "DeferName") @defer(label: "DeferName")
id
Expand Down Expand Up @@ -2019,7 +2019,7 @@ describe('Execute: stream directive', () => {
} = promiseWithResolvers();

const document = parse(`
query {
query {
friendList @stream(initialCount: 1, label:"stream-label") {
...NameFragment @defer(label: "DeferName") @defer(label: "DeferName")
id
Expand Down Expand Up @@ -2131,7 +2131,7 @@ describe('Execute: stream directive', () => {
};

const document = parse(`
query {
query {
friendList @stream(initialCount: 1) {
id
... @defer {
Expand Down Expand Up @@ -2191,7 +2191,7 @@ describe('Execute: stream directive', () => {
};

const document = parse(`
query {
query {
friendList @stream(initialCount: 1) {
name
id
Expand Down Expand Up @@ -2250,7 +2250,7 @@ describe('Execute: stream directive', () => {
}),
};
const document = parse(`
query {
query {
friendList @stream(initialCount: 1) {
... @defer {
name
Expand Down
2 changes: 1 addition & 1 deletion src/utilities/__tests__/printSchema-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ describe('Type System Printer', () => {
schema {
query: Query
}

""""""
directive @someDirective(
""""""
Expand Down