Skip to content

docs: reviewer and merge process #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2024
Merged

docs: reviewer and merge process #4013

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f91110
docs: reviewer and merge process
saihaj Jan 24, 2024
b7e5b9b
fix handle
saihaj Jan 24, 2024
e80d809
Update .github/CONTRIBUTING.md
saihaj Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix handle
  • Loading branch information
@saihaj
saihaj committed Jan 24, 2024
commit b7e5b9be5301e931762014cc93def193858d9877
6 changes: 3 additions & 3 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,12 @@ ensure your pull request matches the style guides, run `npm run prettier`.
## Review Process

- Pull requests are required to pass all tests and checks before they can be merged.
- Pull requests should be reviewed by _at least two_ members of the [`@graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team before they can be merged.
- If a reviewer hasn't responded in 48 hours, feel free to ping them `@graphql-js-reviewers`.
- Pull requests should be reviewed by _at least two_ members of the [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team before they can be merged.
- If a reviewer hasn't responded in 48 hours, feel free to ping them `@graphql/graphql-js-reviewers`.

## Merge Process

Once a pull request has been approved by 2 reviewers from [`@graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team, we must wait 2 weeks before merging the pull request, this allows for other reviewers to give feedback without rushing any merges. Pull request can be merged by a member of the [`@graphql-js-reviewers-write`](https://github.com/orgs/graphql/teams/graphql-js-reviewers-write) team.
Once a pull request has been approved by 2 reviewers from [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team, we must wait 2 weeks before merging the pull request, this allows for other reviewers to give feedback without rushing any merges. Pull request can be merged by a member of the [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers-write) team.

## Release on NPM

Expand Down