Skip to content

backport[v16]: Introduce "recommended" validation rules #4119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 21, 2024
Merged

backport[v16]: Introduce "recommended" validation rules #4119

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
db589b7
impl
enisdenjo May 20, 2024
e3c6ec1
Add test to check how we handle infinite recursion
benjie May 23, 2024
c2479a2
Fix infinite recursion bug
benjie May 23, 2024
18d6927
Lint
benjie May 23, 2024
784b74f
Excessive efficiency
benjie May 23, 2024
b348626
Merge pull request #6 from graphql/maxintfields-16-infinite-recursion
enisdenjo Jun 3, 2024
0706274
on create
enisdenjo Jun 3, 2024
0e0a7a8
in specified rules
enisdenjo Jun 3, 2024
bd6dcb5
reorder
enisdenjo Jun 3, 2024
c10935f
comment
enisdenjo Jun 19, 2024
8d14383
Introduce max introspection depth rule
enisdenjo May 20, 2024
c40e054
Move recommended rules into their own array
benjie Jun 21, 2024
294f199
Move recommended rules into their own array
benjie Jun 21, 2024
d74c6c6
Merge branch '16.x.x' into maxintfields-16
benjie Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reorder
  • Loading branch information
@enisdenjo
enisdenjo committed Jun 3, 2024
commit bd6dcb5f0399cc321515bfd905dbd749c20b9b30
4 changes: 2 additions & 2 deletions src/validation/specifiedRules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ import { KnownFragmentNamesRule } from './rules/KnownFragmentNamesRule';
import { KnownTypeNamesRule } from './rules/KnownTypeNamesRule';
// Spec Section: "Lone Anonymous Operation"
import { LoneAnonymousOperationRule } from './rules/LoneAnonymousOperationRule';
import { MaxIntrospectionDepthRule } from './rules/MaxIntrospectionDepthRule';
// SDL-specific validation rules
import { LoneSchemaDefinitionRule } from './rules/LoneSchemaDefinitionRule';
import { MaxIntrospectionDepthRule } from './rules/MaxIntrospectionDepthRule';
// Spec Section: "Fragments must not form cycles"
import { NoFragmentCyclesRule } from './rules/NoFragmentCyclesRule';
// Spec Section: "All Variable Used Defined"
Expand Down Expand Up @@ -99,9 +99,9 @@ export const specifiedRules: ReadonlyArray<ValidationRule> = Object.freeze([
ValuesOfCorrectTypeRule,
ProvidedRequiredArgumentsRule,
VariablesInAllowedPositionRule,
MaxIntrospectionDepthRule,
OverlappingFieldsCanBeMergedRule,
UniqueInputFieldNamesRule,
MaxIntrospectionDepthRule,
]);

/**
Expand Down