Skip to content

fix sidebar for documentation and /api-v16 #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 29, 2025

Conversation

dimaMachina
Copy link
Contributor

No description provided.

@dimaMachina dimaMachina requested a review from a team as a code owner January 21, 2025 08:43
Copy link

Hi @dimaMachina, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@@ -27,6 +28,7 @@ export default withNextra({
});
return config;
},
redirects: async () => vercel.redirects,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to have same redirects locally

Comment on lines 2 to 4
docs: {
type: 'page',
title: 'Documentation'
Copy link
Contributor Author

@dimaMachina dimaMachina Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to group mdx pages under some folder and set type: page so we'll have proper sidebar

@@ -4,7 +4,6 @@ module.exports = {
content: [
'./pages/**/*.{ts,tsx,mdx}',
'./icons/**/*.{ts,tsx,mdx}',
'./css/**/*.css',
Copy link
Contributor Author

@dimaMachina dimaMachina Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not include *.css for tailwindcss

@@ -7,12 +7,12 @@ GraphQL.JS is the reference implementation to the [GraphQL Specification](https:
while closely following the Specification.

You can build GraphQL servers, clients, and tools with this library, it's designed so you can choose which parts you use, for example, you can build your own parser
and use the execution/validation from the library. There also a lot of useful utilities for schema-diffing, working with arguments and [many more](./utilities.mdx).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link is 404, so I removed it cc @JoviDeCroock

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, should I use this link instead?

Copy link
Member

@benjie benjie Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an evergreen link that can be used instead? like graphql-js.org/api-latest/utilities?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if not, then yeah might as well I guess 👍

@JoviDeCroock JoviDeCroock merged commit 8296fbf into graphql:16.x.x Jan 29, 2025
15 of 17 checks passed
JoviDeCroock added a commit that referenced this pull request May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants