Skip to content

Update subscribe function to return a Promise of AsyncIterator or ExecutionResult #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 14, 2017
Merged

Update subscribe function to return a Promise of AsyncIterator or ExecutionResult #918

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e2f4d9f
Report or Reject when encountering Errors.
leebyron May 26, 2017
02ded50
Subscriptions: Respond with error when failing to create source
leebyron May 26, 2017
1d937d2
Subscriptions: Test source errors and execution errors.
leebyron May 27, 2017
15b8251
Update subscribe signature to return a promise of AsyncIterator/Error…
Jun 15, 2017
9c377ce
Throw errors instead of returning them from Subscribe()
Jun 16, 2017
8816dbf
Lint, refactor error mapper and add comments
Jun 16, 2017
09f3c11
Report or Reject when encountering Errors.
leebyron May 26, 2017
0132123
Subscriptions: Respond with error when failing to create source
leebyron May 26, 2017
e489ad4
Subscriptions: Test source errors and execution errors.
leebyron May 27, 2017
a947ca5
Update subscribe signature to return a promise of AsyncIterator/Error…
Jun 15, 2017
acf5041
Throw errors instead of returning them from Subscribe()
Jun 16, 2017
fedd7fd
Lint, refactor error mapper and add comments
Jun 16, 2017
2fc393b
Merge branch 'subscription-promise-union' of https://github.com/graph…
Jun 18, 2017
3c166a0
Update test case assertions for stream errors to be more precise
Jun 18, 2017
8a8bf4b
Add test case for wrong variable types
Jul 11, 2017
ff6c202
Fix lint error (extra spaces)
Jul 11, 2017
d70e4d5
Fix multi-line doc block format
Jul 14, 2017
3ed9ad2
Minor edits
leebyron Aug 14, 2017
3f52a41
Trim trailing whitespace
leebyron Aug 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix multi-line doc block format
  • Loading branch information
Robert Zhu committed Jul 14, 2017
commit d70e4d5570733d7374d8e5e8d2ec963e4d16dded
8 changes: 4 additions & 4 deletions src/subscription/subscribe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,10 @@ export function subscribe(
}

/**
/* This function checks if the error is a GraphQLError. If it is, convert it to
/* an ExecutionResult interface, containing only errors and no value. Otherwise
/* treat the error as a system-class error and throw it.
*/
* This function checks if the error is a GraphQLError. If it is, convert it to
* an ExecutionResult interface, containing only errors and no value. Otherwise
* treat the error as a system-class error and throw it.
*/
function convertOrThrowError(error) {
if (error instanceof GraphQLError) {
return { errors: [ error ] };
Expand Down