defer cancel() leaks memory #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
requested changes
Feb 11, 2025
Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
johanbrandhorst
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Immediately call cancel() after we are done using the context. The for loop doesn't return until we succeed or parentCtx is cancelled if this takes a long time defer will never be called and this leaks memory.
In combination with the overflow here #747 this leaks memory quite fast when the retry loops starts running every 0s because of the overflow.
Verification
Ran a small piece of code calling an unavailable service and pprofed it.