Skip to content

update gradle to 7.6 #9802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gelpenaddict opened this issue Jan 10, 2023 · 5 comments · Fixed by #9803
Closed

update gradle to 7.6 #9802

gelpenaddict opened this issue Jan 10, 2023 · 5 comments · Fixed by #9803
Assignees
@ejona86
Milestone
1.53

Comments

@gelpenaddict
Copy link

gelpenaddict commented Jan 10, 2023 •
edited
Loading

What version of gRPC-Java are you using?

v1.51.1

What is your environment?

MacOS 13.1
JDK 19

What did you expect to see?

successful execution of ./gradlew installDist

What did you see instead?

java.lang.illegalargumentexception: unsupported class file major version 63

Steps to reproduce the bug

./gradlew installDist

The solution was to update gradle distrubtionUrl's to:

distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip

JDK19 support was added in Gradle 7.6: https://docs.gradle.org/7.6/release-notes.html
@ejona86
Copy link
Member

ejona86 commented Jan 10, 2023

I actually was already working on a change to upgrade (I was waiting for #9790 and hadn't sent it out yet).

Would you mind sharing why you were building grpc-java and with JDK 19? Were you just wanting to run our tests against JDK 19?

@ejona86 ejona86 self-assigned this Jan 10, 2023
@ejona86 ejona86 added this to the 1.53 milestone Jan 10, 2023
@gelpenaddict
Copy link
Author

I got a new machine so I was installing Java and picked the latest. 19 has been out for a few months already so was surprised it wasn't updated here. I was just doing the tutorial to learn it, not sure what tests you're referring to. I'm also not a Gradle expert so not sure if changing that distributionUrl is the proper way to update it.

@ejona86
Copy link
Member

ejona86 commented Jan 10, 2023

I was just doing the tutorial to learn it

Oh, you were probably in the examples/ directory. Yeah, it would be good to get that working on newer JDK versions pretty soon.

ejona86 added a commit to ejona86/grpc-java that referenced this issue Jan 10, 2023
@ejona86
Bump to Gradle 7.6 and update plugins
ddb3ae6 
As normal, Android versions weren't touched as it tends to be special to
upgrade.

The errorprone plugin handles errorproneJavac for us now, since it
hasn't changed in five years. VERSION_CATALOGS is already enabled by
default and graduated out of preview.

Fixes grpc#9802
@ejona86 ejona86 mentioned this issue Jan 10, 2023
Merged
ejona86 added a commit that referenced this issue Jan 11, 2023
@ejona86
Bump to Gradle 7.6 and update plugins
eb391fd 
As normal, Android versions weren't touched as it tends to be special to
upgrade.

The errorprone plugin handles errorproneJavac for us now, since it
hasn't changed in five years. VERSION_CATALOGS is already enabled by
default and graduated out of preview.

Fixes #9802
@gelpenaddict
Copy link
Author

Thx for updating. The quickstart page's git clone command still pulls the old Gradle version. How do we pull the update?

@ejona86
Copy link
Member

ejona86 commented Jan 17, 2023

@gelpenaddict, it will do so until we bump the version for the next release.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ejona86 ejona86

Labels
None yet
Projects
None yet
Milestone
1.53
Development

Successfully merging a pull request may close this issue.

Bump to Gradle 7.6 and update plugins ejona86/grpc-java
2 participants
@ejona86 @gelpenaddict