Skip to content

protobuf,protobuf-lite: configurable protobuf recursion limit #10094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 2, 2023
Merged

protobuf,protobuf-lite: configurable protobuf recursion limit #10094

merged 7 commits into from
May 2, 2023

Conversation

kloyan
Copy link
Contributor

@kloyan kloyan commented Apr 23, 2023

Resolves #9643

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 23, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kloyan / name: Kaloyan Simitchiyski (765bfb1)

@sanjaypujare sanjaypujare requested a review from ejona86 April 24, 2023 16:43
@sanjaypujare sanjaypujare mentioned this pull request Apr 24, 2023
Closed
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 27, 2023
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 27, 2023
@kloyan kloyan mentioned this pull request Apr 27, 2023
Closed
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 27, 2023
@ejona86 ejona86 requested a review from sergiitk April 27, 2023 20:51
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 27, 2023
sergiitk
sergiitk approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the contribution. Left one nit, but it's good to merge as is.

@kloyan @sergiitk
Fix formatting
aeb4797 
Co-authored-by: Sergii Tkachenko <[email protected]>
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label May 2, 2023
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label May 2, 2023
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label May 2, 2023
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label May 2, 2023
@ejona86 ejona86 merged commit 572a7af into grpc:master May 2, 2023
@ejona86
Copy link
Member

ejona86 commented May 2, 2023

@kloyan, thank you!

@kloyan kloyan deleted the feat/9643 branch May 3, 2023 11:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiitk sergiitk sergiitk approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support configuring a deeper recursion limit for protobuf deserialization
4 participants
@kloyan @ejona86 @sergiitk @grpc-kokoro