Support retrieving the names from wrapped resource containers. #10975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly, the xDS library only honors names that are retrieved from the inner resource containers, but for wrapped resources the outer layer could contain the required name in either the Name or in the ResourceName.Name fields. So this PR allows fallback for those conditions. The priority is 1. Inner Resource Name 2. Name on the wrapped container 3. Name on the ResourceName.Name container. The fallback to other priorities occur when the fields are empty
ejona86
reviewed
Mar 4, 2024
…rce.ResourceName for now. Also provide a higher priority for wrapped resource name over the inner resource name
ejona86
reviewed
Mar 5, 2024
ejona86
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the xDS library only honors names that are retrieved from the inner resource containers, but for wrapped resources the outer layer could contain the required name in either the Name or in the ResourceName.Name fields.
So this PR allows fallback for those conditions. The priority is
The fallback to other priorities occur when the higher priority fields are empty.
cc: @YifeiZhuang , @larry-safran, @ejona86