Skip to content

xds: Use empty string when disabling server hostname verification #11052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

kannanjgithub
Copy link
Contributor

@kannanjgithub kannanjgithub commented Mar 28, 2024

Setting a null endpoint identification algorithm gets ignored in Sun's
SSLEngine implementation.

Fixes #10810.

…m to disable server hostname verification, since null value gets ignored in Sun's SSLEngine implementation.
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 28, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 28, 2024
@ejona86 ejona86 changed the title xds: Use empty string instead of null for endpoint identification algorith… xds: Use empty string when disabling server hostname verification Mar 28, 2024
@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Mar 28, 2024
@ejona86 ejona86 merged commit 097a46b into grpc:master Mar 28, 2024
15 checks passed
@ejona86 ejona86 deleted the xdssslendpointalgoemptystring branch March 28, 2024 23:58
@YifeiZhuang YifeiZhuang removed the TODO:backport PR needs to be backported. Removed after backport complete label Apr 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xDS with TrafficDirector and spiffe: CertificateException: no name matching foo.bar found
4 participants