Change HappyEyeballs and new pick first LB flags default value to false #11120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temawi
approved these changes
Apr 22, 2024
|
I'm assuming no existing customer is yet relaying on this to be the default behavior. |
larry-safran
force-pushed
the
disable_happy_eyeballs
branch
from
7723076 to
dd6d125
Compare
|
Since it is only an optimization speeding up initial connection when some
targets are being slow, it shouldn't break anyone to not have it. It looks
like the current concerns are because of the extra threads used for the
alternate connections.
…On Mon, Apr 22, 2024 at 4:29 PM Terry Wilson ***@***.***> wrote:
I'm assuming no existing customer is yet relaying on this to be the
default behavior.
—
Reply to this email directly, view it on GitHub
<#11120 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZQMCXT4TC7LM4KUMQNZAP3Y6WMMXAVCNFSM6AAAAABGTVP7H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZRGEYTONRYGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
larry-safran
changed the title
…are seeing problems. Put the flag logic in a common place for PickFirstLeafLoadBalancer & WRR's test.
…is enabled or not
larry-safran
force-pushed
the
disable_happy_eyeballs
branch
from
622e2cd to
500f767
Compare
larry-safran
added
the
TODO:backport
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
May 8, 2024
…se (grpc#11120) * Change HappyEyeballs flag default value to false since some G3 users are seeing problems. Put the flag logic in a common place for PickFirstLeafLoadBalancer & WRR's test. * Set expected requestConnection count based on whether happy eyeballs is enabled or not * Disable new PickFirstLB * Fix test expectations to handle both new and old PF LB paths.
larry-safran
added a commit
that referenced
this pull request
May 8, 2024
…se (#11120) (#11177) * Change HappyEyeballs flag default value to false since some G3 users are seeing problems. Put the flag logic in a common place for PickFirstLeafLoadBalancer & WRR's test. * Set expected requestConnection count based on whether happy eyeballs is enabled or not * Disable new PickFirstLB * Fix test expectations to handle both new and old PF LB paths.
ejona86
removed
the
TODO:backport
This was referenced May 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some g3 users are seeing problems.
Put the flag logic in a common place for PickFirstLeafLoadBalancer & WRR's test.