-
Notifications
You must be signed in to change notification settings - Fork 3.9k
api: Add java.time.Duration overloads to CallOptions, AbstractStub #11562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
ab97045
SynchronizationContextTest changes for scheduleFixedDelay with Duration
SreeramdasLavanya fef4c92
Revert "SynchronizationContextTest changes for scheduleFixedDelay wit…
SreeramdasLavanya 6a713ed
SynchronizationContextTest changes for scheduleFixedDelay with Duration
SreeramdasLavanya db6c21f
SynchronizationContextTest checkstyle issues updated for issue10245
SreeramdasLavanya 778cfb4
Merge branch 'grpc:master' into master
SreeramdasLavanya 328bcbf
Merge branch 'grpc:master' into master
SreeramdasLavanya 6a66054
Merge branch 'grpc:master' into master
SreeramdasLavanya 84a37e9
Issue 10245 fix for long, TimeUnit to java.time.Duration to API's
SreeramdasLavanya c1090b7
Issue 10245 - Fixed Checkstyle issues
SreeramdasLavanya 6c56aae
Issue 10245 - Fixed Checkstyle issues
SreeramdasLavanya 4113845
Merge branch 'grpc:master' into master
SreeramdasLavanya 4531bc2
Issue 10245 - Reverted java.time.Duration changes for Deadline and De…
SreeramdasLavanya 09c3509
Merge branch 'grpc:master' into master
SreeramdasLavanya bd5a80a
Issue 10245 - Implementation for Duration.toNanos() changes
SreeramdasLavanya e64f659
grpc-api/stub: Implementation for InternalTimeUtil under grpc-api module
SreeramdasLavanya 0b6c594
grpc-api/stub: Added JUnit for the InternalTimeUtils changes
SreeramdasLavanya 4d0aa82
Merge branch 'master' into FixIssue10245
SreeramdasLavanya 62a88ec
Merge branch 'grpc:master' into master
SreeramdasLavanya b905dfa
Merge branch 'master' into FixIssue10245
SreeramdasLavanya eb66fe5
grpc-api/stub: Modified JUnit for the InternalTimeUtils changes
SreeramdasLavanya e76d673
grpc-api: Whitespace formatting for unrelated code
SreeramdasLavanya f01209b
grpc-api: Whitespace formatting for unrelated code and Reverted stati…
SreeramdasLavanya de2e185
grpc-api: Reverted static import for InternalTimeUtils.convert method
SreeramdasLavanya 7207da8
grpc-api/stub: Renamed InternalTimeUtils to TimeUtils and its effecte…
SreeramdasLavanya bf6c521
grpc-api: Formatted whitespaces
SreeramdasLavanya af01908
grpc-api/stub: Renamed convert() method to convertToNanos()
SreeramdasLavanya 3dbb61e
grpc-api/stub: Changes for InternalTimeUtils and TimeUtils files as p…
SreeramdasLavanya 7e46762
grpc-api/stub: Checkstyle issue
SreeramdasLavanya e530050
grpc-api/stub: Check style issue for InternalTimeUtils
SreeramdasLavanya 7d9bfdf
grpc-api/stub: Included @ExperimentalApi for public API.
SreeramdasLavanya 301ff57
grpc-api/stub: Included @ExperimentalApi for public API's those recei…
SreeramdasLavanya de91ea3
Merge branch 'grpc:master' into FixIssue10245
SreeramdasLavanya 27df5f9
grpc-api/stub: Included schedule() with Duration
SreeramdasLavanya 89afd10
grpc-api: Included private constructor
SreeramdasLavanya 75c8955
grpc-api: Fix checkstyle issue
SreeramdasLavanya 1dd8bbc
Merge branch 'grpc:master' into FixIssue10245
SreeramdasLavanya 761a812
grpc-api/stub: Created new issue for ExperimentalApi
SreeramdasLavanya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Issue 10245 - Fixed Checkstyle issues
- Loading branch information
commit c1090b72c13bfa72116eb2a5f28d2e7bb457edcf
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a concern about the loss of precision, I have raised a question on Eric's comment to use TimeUnit.NANOSECONDS.convert(duration) instead of Duration.toNano().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Eric replied, you should be using https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/concurrent/TimeUnit.html#convert(java.time.Duration) and not have to convert using the seconds value.