inprocess: Support tracing message sizes guarded by flag #11629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -212,6 +215,7 @@ public ServerStreamTracer newServerStreamTracer(String fullMethodName, Metadata | |||
|
|
|||
| @Before | |||
| public void setUp() { | |||
| System.setProperty(GRPC_EXPERIMENTAL_SUPPORT_TRACING_MESSAGE_SIZES, "true"); | |||
There was a problem hiding this comment.
You should do this in the specific test, not here which is the setup step for every test. We need to have 2 tests one that sets the property and one that doesn't. The test that does setProperty should have a try - finally block to System.clearProperty in the finally block as well.
There was a problem hiding this comment.
Since we would expect to have this flag for ~1 week and we want to get this in quickly (vs the larger revert), I suggest not testing at all with GRPC_EXPERIMENTAL_SUPPORT_TRACING_MESSAGE_SIZES=true (just use the default, whatever it is).
ejona86
reviewed
Oct 22, 2024
inprocess/src/main/java/io/grpc/inprocess/InProcessTransport.java
Outdated
Show resolved
Hide resolved
|
We shouldn't do this every message.
What does that mean? You mean we should move it to somewhere else? Perhaps
to a place where constants are defined?
…On Tue, 22 Oct 2024 at 8:19 PM, Eric Anderson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In inprocess/src/main/java/io/grpc/inprocess/InProcessTransport.java
<#11629 (comment)>:
> @@ -358,6 +358,13 @@ private static int metadataSize(Metadata metadata) {
return (int) size;
}
+ /**
+ * Returns true if env var is set.
+ */
+ static boolean isEnabledSupportTracingMessageSizes() {
+ return GrpcUtil.getFlag("GRPC_EXPERIMENTAL_SUPPORT_TRACING_MESSAGE_SIZES", false);
We shouldn't do this every message.
—
Reply to this email directly, view it on GitHub
<#11629 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANRG3B6XM6IKQYRKNTFRBRTZ4ZQWXAVCNFSM6AAAAABQMLV5L6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOBVGQ2TKOJXGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Add it as a field to the transport. |
ejona86
approved these changes
Oct 23, 2024
ejona86
approved these changes
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.