Skip to content

Deframe failures should be logged on the server as warnings #11645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Deframe failures should be logged on the server as warnings #11645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions servlet/src/main/java/io/grpc/servlet/ServletServerStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@

@Override
public void deframeFailed(Throwable cause) {
if (logger.isLoggable(FINE)) {
logger.log(FINE, String.format("[{%s}] Exception processing message", logId), cause);
if (logger.isLoggable(WARNING)) {
logger.log(WARNING, String.format("[{%s}] Exception processing message", logId), cause);

Check warning on line 158 in servlet/src/main/java/io/grpc/servlet/ServletServerStream.java

View check run for this annotation

Codecov / codecov/patch

servlet/src/main/java/io/grpc/servlet/ServletServerStream.java#L158 

Added line #L158 was not covered by tests
}
cancel(Status.fromThrowable(cause));
}
Expand Down