Skip to content

Let AndroidComponentAddress specify a target UserHandle #11670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert whitespace
  • Loading branch information
jdcormie committed Nov 6, 2024
commit ced05baaed746e0356da2fff95ace77b039783c5
8 changes: 4 additions & 4 deletions binder/src/main/java/io/grpc/binder/BinderChannelBuilder.java
Original file line number Diff line number Diff line change
Expand Up @@ -246,10 +246,10 @@ public BinderChannelBuilder securityPolicy(SecurityPolicy securityPolicy) {
* normally reserved for system apps. See {@link android.content.Context#bindServiceAsUser} for
* details.
*
* @deprecated This method's name is confusing since it implies impersonation. It's also no longer
* necessary since the target user is now part of the {@link AndroidComponentAddress}. Prefer
* to specify your target there instead, either as a direct address or via a
* {@link io.grpc.NameResolverProvider}.
* @deprecated This method's name is misleading because it implies an impersonated client identity
* when it's actually specifying part of the server's location. It's also no longer necessary
* since the target user is part of {@link AndroidComponentAddress}. Prefer to specify target
* user in the address instead, either directly or via a {@link io.grpc.NameResolverProvider}.
* @param targetUserHandle the target user to bind into.
* @return this
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -299,10 +299,7 @@ protected boolean setOutgoingBinder(OneWayBinderProxy binder) {

@Override
public synchronized void binderDied() {
shutdownInternal(
Status.UNAVAILABLE.withDescription(
"Peer process crashed, exited or was killed (binderDied)"),
true);
shutdownInternal(Status.UNAVAILABLE.withDescription("Peer process crashed, exited or was killed (binderDied)"), true);
}

@GuardedBy("this")
Expand Down