Skip to content

xds: fixed unsupported unsigned 32 bits issue for circuit breaker #11735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 17, 2024
Merged

xds: fixed unsupported unsigned 32 bits issue for circuit breaker #11735

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77f48d5
xds: fixed unsupported unsigned 32 bits issue for circuit breaker
vinodhabib Dec 10, 2024
7b16a6a
xds: added junit case for change
vinodhabib Dec 11, 2024
46216b9
xds: reverted back the junit
vinodhabib Dec 11, 2024
797cf10
xds: added junit case for change
vinodhabib Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
xds: reverted back the junit
  • Loading branch information
@vinodhabib
vinodhabib committed Dec 11, 2024
commit 46216b9c43b861c0c474e4b5912b33cd7ed2a89a
19 changes: 0 additions & 19 deletions xds/src/test/java/io/grpc/xds/GrpcXdsClientImplTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3782,25 +3782,6 @@ public void sendToNonexistentServer() throws Exception {
client.shutdown();
}

@Test
public void circuitBreakingConversionOf32bitIntTo64bitLongForMaxRequestNegativeValue() {
DiscoveryRpcCall call = startResourceWatcher(XdsClusterResource.getInstance(), CDS_RESOURCE,
cdsResourceWatcher);
Any clusterCircuitBreakers = Any.pack(
mf.buildEdsCluster(CDS_RESOURCE, null, "round_robin", null, null, false, null,
"envoy.transport_sockets.tls", mf.buildCircuitBreakers(50, -1), null));
call.sendResponse(CDS, clusterCircuitBreakers, VERSION_1, "0000");

// Client sent an ACK CDS request.
call.verifyRequest(CDS, CDS_RESOURCE, VERSION_1, "0000", NODE);
verify(cdsResourceWatcher).onChanged(cdsUpdateCaptor.capture());
CdsUpdate cdsUpdate = cdsUpdateCaptor.getValue();

assertThat(cdsUpdate.clusterName()).isEqualTo(CDS_RESOURCE);
assertThat(cdsUpdate.clusterType()).isEqualTo(ClusterType.EDS);
assertThat(cdsUpdate.maxConcurrentRequests()).isEqualTo(4294967295L);
}

private XdsClientImpl createXdsClient(String serverUri) {
BootstrapInfo bootstrapInfo = buildBootStrap(serverUri);
return new XdsClientImpl(
Expand Down
Loading