Skip to content

services: fix HealthService notifyWatchers #11934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2025
Merged

services: fix HealthService notifyWatchers #11934

merged 3 commits into from
Mar 25, 2025

Conversation

JoeCqupt
Copy link
Contributor

@JoeCqupt JoeCqupt commented Mar 3, 2025 •
edited
Loading

fix #11853

Use ServerCallStreamObserver.setOnCancelHandler() to disable this exception

@JoeCqupt
Copy link
Contributor Author

JoeCqupt commented Mar 4, 2025 •
edited
Loading

@zhangkun83 @carl-mastrangelo PTAL @kannanjgithub

@JoeCqupt JoeCqupt changed the title fix HealthService notifyWatchers services: fix HealthService notifyWatchers Mar 10, 2025
ejona86
ejona86 reviewed Mar 20, 2025
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to catch the exception. I think we want to avoid the exception by using setOnCancelHandler() as mentioned in the error to update watchers. That will release resources as soon as the RPC is cancelled.

@JoeCqupt JoeCqupt requested a review from ejona86 March 21, 2025 11:54
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 21, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Mar 21, 2025
@ejona86 ejona86 requested a review from kannanjgithub March 24, 2025 21:12
@kannanjgithub kannanjgithub merged commit 350f90e into grpc:master Mar 25, 2025
16 checks passed
@ejona86
Copy link
Member

ejona86 commented Mar 25, 2025

@JoeCqupt, thank you!

Sangamesh1997 pushed a commit to Sangamesh1997/grpc-java that referenced this pull request Apr 3, 2025
@JoeCqupt @Sangamesh1997
services: Avoid cancellation exceptions when notifying watchers that …
036cd41 
…already have their connections cancelled (grpc#11934)

Some clients watching health status can cancel their watch and `HealthService` when trying to notify these watchers were getting CANCELLED exception because there was no cancellation  handler set on the `StreamObserver`. This change sets the cancellation handler that removes the watcher from the set of watcher clients to be notified of the health status.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@kannanjgithub kannanjgithub kannanjgithub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HealthStatusManager.setStatus can throw a runtime exception when notifying (already cancelled) watchers
4 participants
@JoeCqupt @ejona86 @kannanjgithub @grpc-kokoro