Skip to content

stub: fix onError metadata race condition #11979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

Conversation

JoeCqupt
Copy link
Contributor

@JoeCqupt JoeCqupt commented Mar 25, 2025

#11973

this maybe have a little performance implications.

@JoeCqupt
Copy link
Contributor Author

JoeCqupt commented Mar 25, 2025

PTAL @kannanjgithub @ejona86

@kannanjgithub kannanjgithub requested a review from ejona86 April 7, 2025 14:41
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 7, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 7, 2025
@ejona86 ejona86 merged commit 54d3783 into grpc:master Apr 7, 2025
16 checks passed
@ejona86
Copy link
Member

ejona86 commented Apr 7, 2025

Thank you!

ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request Apr 7, 2025
If the same exception is passed to multiple RPCs, then the results will
race.

Fixes grpc#11973
kannanjgithub pushed a commit that referenced this pull request Apr 8, 2025
)

If the same exception is passed to multiple RPCs, then the results will race, which this fix addresses.

Fixes #11973

Co-authored-by: jiangyuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants