Skip to content

prevents global stats config freeze in ConfiguratorRegistry.getConfigurators() #11991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

prevents global stats config freeze in ConfiguratorRegistry.getConfigurators() #11991

merged 2 commits into from
Apr 4, 2025

Conversation

AgraVator
Copy link
Contributor

No description provided.

@AgraVator AgraVator requested review from ejona86 and DNVindhya April 3, 2025 10:55
ejona86
ejona86 reviewed Apr 3, 2025
View reviewed changes
@AgraVator AgraVator requested a review from ejona86 April 3, 2025 14:39
ejona86
ejona86 approved these changes Apr 3, 2025
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had originally considered setConfigurators() returning the count of calls before it was set. But we can consider/change that before we make this API public.

@AgraVator AgraVator merged commit d4c46a7 into grpc:master Apr 4, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@DNVindhya DNVindhya Awaiting requested review from DNVindhya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AgraVator @ejona86