stub: remove interrupt checking from ThreadSafeThreadlessExecutor.drain #12358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only caller of `drain()` just reset the interrupt flag. So, we can avoid the whole exception dance.
benjaminp
force-pushed
the
drain-InterruptedException
branch
from
19cf6f5 to
dedd8b0
Compare
ejona86
approved these changes
Sep 18, 2025
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
shivaspeaks
approved these changes
Sep 22, 2025
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
Sep 26, 2025
…in (grpc#12358) The only caller of `drain()` just reset the interrupt flag. So, we can avoid the whole exception dance.
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
Sep 26, 2025
…in (grpc#12358) The only caller of `drain()` just reset the interrupt flag. So, we can avoid the whole exception dance.
ejona86
added
the
TODO:backport
ejona86
pushed a commit
to ejona86/grpc-java
that referenced
this pull request
Sep 30, 2025
…in (grpc#12358) The only caller of `drain()` just reset the interrupt flag. So, we can avoid the whole exception dance.
AgraVator
removed
the
TODO:backport
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
Oct 6, 2025
…in (grpc#12358) The only caller of `drain()` just reset the interrupt flag. So, we can avoid the whole exception dance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only caller of
drain()just reset the interrupt flag. So, we can avoid the whole exception dance.