-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Static authorization server interceptor implementation #8934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+629
−15
Merged
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1eb6932
Static authorization server interceptor implementation
ashithasantosh 3a0b5e5
Resolving comments
ashithasantosh 7860f4d
Remove RbacParser file
ashithasantosh 8538102
update error logs
ashithasantosh 3d6fa39
checkstyle fixes
ashithasantosh 277d09a
Merge remote-tracking branch 'upstream/master' into interceptor_impl
ashithasantosh ce7e346
Merge remote-tracking branch 'upstream/master' into interceptor_impl
ashithasantosh c9bd220
Add InternalRbacFilter
ashithasantosh 4172908
formatting
ashithasantosh 2a28350
javadoc
ashithasantosh 1b8f89c
format test file
ashithasantosh 3bf61dc
resolving comments
ashithasantosh 421265f
Merge remote-tracking branch 'upstream/master' into interceptor_impl
ashithasantosh fb79c74
minor formatting
ashithasantosh 10e973d
Update comment
ashithasantosh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
authz/src/main/java/io/grpc/authz/AuthorizationServerInterceptor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
/* | ||
* Copyright 2022 The gRPC Authors | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package io.grpc.authz; | ||
|
||
import static com.google.common.base.Preconditions.checkNotNull; | ||
|
||
import io.envoyproxy.envoy.config.rbac.v3.RBAC; | ||
import io.grpc.ExperimentalApi; | ||
import io.grpc.InternalServerInterceptors; | ||
import io.grpc.Metadata; | ||
import io.grpc.ServerCall; | ||
import io.grpc.ServerCallHandler; | ||
import io.grpc.ServerInterceptor; | ||
import io.grpc.xds.InternalRbacFilter; | ||
import java.io.IOException; | ||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
/** | ||
* Authorization server interceptor for static policy. | ||
*/ | ||
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/9746") | ||
public final class AuthorizationServerInterceptor implements ServerInterceptor { | ||
private final List<ServerInterceptor> interceptors = new ArrayList<>(); | ||
|
||
private AuthorizationServerInterceptor(String authorizationPolicy) | ||
throws IllegalArgumentException, IOException { | ||
List<RBAC> rbacs = AuthorizationPolicyTranslator.translate(authorizationPolicy); | ||
if (rbacs == null || rbacs.isEmpty() || rbacs.size() > 2) { | ||
throw new IllegalArgumentException("Failed to translate authorization policy"); | ||
} | ||
for (RBAC rbac: rbacs) { | ||
interceptors.add( | ||
InternalRbacFilter.createInterceptor( | ||
io.envoyproxy.envoy.extensions.filters.http.rbac.v3.RBAC.newBuilder() | ||
.setRules(rbac).build())); | ||
} | ||
} | ||
|
||
@Override | ||
public <ReqT, RespT> ServerCall.Listener<ReqT> interceptCall( | ||
ServerCall<ReqT, RespT> call, Metadata headers, | ||
ServerCallHandler<ReqT, RespT> next) { | ||
for (ServerInterceptor interceptor: interceptors) { | ||
next = InternalServerInterceptors.interceptCallHandlerCreate(interceptor, next); | ||
} | ||
return next.startCall(call, headers); | ||
} | ||
|
||
// Static method that creates an AuthorizationServerInterceptor. | ||
ejona86 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
public static AuthorizationServerInterceptor create(String authorizationPolicy) | ||
throws IllegalArgumentException, IOException { | ||
ejona86 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
checkNotNull(authorizationPolicy, "authorizationPolicy"); | ||
return new AuthorizationServerInterceptor(authorizationPolicy); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.