Skip to content

Conversation

@tbetbetbe
Copy link
Contributor

  • fixes the shebang line by moving it above the copyright notice in
    executables.
  • also fixes the execution bit on all the binaries

- fixes the shebang line by moving it above the copyright notice in
  executables.

- also fixes the execution bit on all the binaries
ctiller added a commit that referenced this pull request Jan 13, 2015
@ctiller ctiller merged commit 6469cbf into grpc:master Jan 13, 2015
@tbetbetbe tbetbetbe deleted the grpc_rb_fix_shebang branch January 13, 2015 20:29
@yang-g yang-g mentioned this pull request Feb 10, 2015
jtattermusch referenced this pull request in jtattermusch/grpc Jun 10, 2015
stanley-cheung referenced this pull request in stanley-cheung/grpc Aug 27, 2015
grand unified hello world
jmptrader added a commit to jmptrader/grpc that referenced this pull request Dec 26, 2016
ctiller pushed a commit that referenced this pull request Jan 4, 2017
kskalski added a commit to kskalski/grpc that referenced this pull request Jun 28, 2017
# This is the 1st commit message:
# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 14 commits.
# This is the 1st commit message:
Make CMake find_package work for preinstalled libprotobuf on Raspbian.

# This is the commit message grpc#2:

Add pthread detection and library reference. Add protobuf library reference to grpc_plugin_support.

# This is the commit message grpc#3:

Make cmake protobuf detection changes in template.

# This is the commit message grpc#4:

Package name needs to start with uppercase for find_package(Protobuf)

# This is the commit message grpc#5:

Add pthread detection and library reference. Add protobuf library reference to grpc_plugin_support.

# This is the commit message grpc#6:

Make cmake protobuf detection changes in template.

# This is the commit message grpc#7:

Package name needs to start with uppercase for find_package(Protobuf)

# This is the commit message grpc#8:

Uppercase variable names to match convention of the whole file.

# This is the commit message grpc#9:

Add pthread detection and library reference. Add protobuf library reference to grpc_plugin_support.

# This is the commit message grpc#10:

Merge corrections.

# This is the commit message grpc#11:

Parametrize package provider mode for find_package protobuf.

# This is the commit message grpc#12:

Change package type variable name. Use variant uppercase variable for checking protobuf package presence.

# This is the commit message grpc#13:

Lowercase variand of protobuf found check in find command.

# This is the commit message grpc#14:

Add rule to include protobuf dirs.

# This is the commit message grpc#2:

Add pthread detection and library reference. Add protobuf library reference to grpc_plugin_support.

# The commit message grpc#2 will be skipped:

#	Add pthread detection and library reference. Add protobuf library reference to grpc_plugin_support.

# The commit message grpc#2 will be skipped:

#	Add pthread detection and library reference. Add protobuf library reference to grpc_plugin_support.

# The commit message grpc#3 will be skipped:

#	Merge corrections.
lalo pushed a commit to lalo/grpc that referenced this pull request Oct 19, 2017
Update OS X instruction for homebrew Python
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2019
@veblush veblush added the release notes: no Indicates if PR should not be in release notes label Jun 21, 2019
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@ctiller
Copy link
Member

ctiller commented Jun 21, 2019

@nicolasnoble is someone drunk?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kind/bug release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants