Add "tflint" Hook

[Tensho]

No description provided.

[yorinasub17]

Thanks for your contribution! Same comment as the terraform validate PR.

Also, in the future, please split out commits for each PR so that the diff is not repeated across multiple PRs. If you need to build on older PRs, it is better to either hold off opening the PR, or open another PR against the original one. It makes it hard to review the actual changes when it is mixed with the other PR diffs.

[yorinasub17]

Same issue as the terraform validate PR

[Tensho]

tflint can work with files and directories. IMHO, if the tool may work with files, we should leverage on the pre-commit's parallelization default.

[yorinasub17]

Sounds good. The only reason why I highlighted that was because you were using dirname.

[Tensho]

@yorinasub17 Sorry for the inconvenience, you are totally right. I did this way because I had to refer to the overall changes in my project somehow. But it's kind of selfish, there is no excuse for me. I'll split them up carefully.

[yorinasub17]

But it's kind of selfish, there is no excuse for me. I'll split them up carefully.

No worries! That was just a request.

I did this way because I had to refer to the overall changes in my project somehow.

The workflow I use is to commit each change set individually (using git add -p), then create branches for each change and use git cherry-pick. That way, I have a branch with everything, but also the split versions. For a small number of change sets, it works well. It can be tedious with lots of changes though.

[yorinasub17]

Another approach is to work backwards:

• Have a branch with all the commits
• Create new branches for each change set to turn into PR from the combined branch
• Use git rebase -i to drop the irrelevant commits from each subbranch.

[Tensho]

@yorinasub17 Please let me know if I can do anything else 🙇

[yorinasub17]

You'll need to resolve the conflict now that I merged the terraform-validate PR.

[Tensho]

@yorinasub17 Resolved

[Tensho]

@yorinasub17 Please let me know if I can do anything here 🙇

[yorinasub17]

Sorry for the delay (we were out on vacation during the holiday weeks).

The updated changes LGTM so will be merging this.

[Tensho]

@yorinasub17 That's OK ⛄️ ❄️ 🏂 Thank you 🙇 Happy New Year!