Fix terraform fmt hook where it is now running on all files regardless of exclude #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
approved these changes
Feb 7, 2020
hooks/terraform-fmt.sh
Outdated
| terraform fmt -recursive | ||
| for file in "$@"; do | ||
| tmp_file="$(mktemp)" | ||
| terraform fmt - <"$file" >"$tmp_file" |
There was a problem hiding this comment.
-write=true I think will do what you need
There was a problem hiding this comment.
Thanks. My problem was that the docs was saying the args are DIR, not FILE but it turns out it works fine with files.
|
Thanks for review! Merging and releasing. |
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug with our terraform fmt hook that was introduced in #15.
Specifically,
terraform fmt -rignores the exclude configuration. This makes it hard for our repos that are testing malformed terraform files as they will never pass theterraform fmtprecommit hook.Instead, we go through each file to run through
terraform fmt.