Check skipenv #24
Check skipenv #24
Conversation
| unit_test: | ||
| machine: | ||
| enabled: true | ||
| image: "ubuntu-1604:201903-01" |
There was a problem hiding this comment.
Do we need the machine executor here? Or would tests run faster in a Docker executor?
There was a problem hiding this comment.
Yes, so that I can run against py2 and py3.
hooks/check_skip_env.py
Outdated
| def has_setenv_skip(fpath): | ||
| with open(fpath) as f: | ||
| for line in f: | ||
| if re.match(r'^\s+os.Setenv\(\"SKIP_', line): |
There was a problem hiding this comment.
It's not likely, but perhaps possible someone calls os.Setenv right at the start of a line of code? Also, there may be extra whitespace.
| if re.match(r'^\s+os.Setenv\(\"SKIP_', line): | |
| if re.match(r'^\s*os.Setenv\s*\(\s*\"SKIP_', line): |
Also, consider checking for os.Setenv("TERRATEST_REGION
There was a problem hiding this comment.
It's not likely, but perhaps possible someone calls os.Setenv right at the start of a line of code? Also, there may be extra whitespace.
This would be formatted away with go fmt, so I don't think it is necessary.
Also, consider checking for os.Setenv("TERRATEST_REGION
Added in! e20ca37
|
Ok going to merge and release. Thanks for review! |
Introduce a pre-commit hook that uses a regex based method of checking for uncommented
os.Setenvcalls for setting terratest skip environments.