Skip to content

Support tfenv+tgenv #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Conversation

AlainODea
Copy link
Contributor

Invoke terraform and terragrunt from the directory of the file being checked. This allows tfenv and tgenv to load the correct versions of terraform and terragrunt in a mixed-version repository.

This is for the same reasons as gruntwork-io/module-ci#150:

tfenv loads the correct terraform version based on a file called .terraform_version in the present working directory. Prior to this change, terraform-update-variable would use the root of the cloned repo as the present working directory and select a potentially incompatible version of terraform.

Invoke terraform and terragrunt from the directory of the file being checked.
@brikis98
Copy link
Member

Thanks for the PR! I'm super booked this week, but will try to take a look in the next few days.

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! Found one minor issue, but other than that should be able to merge this in.

@AlainODea AlainODea requested a review from yorinasub17 June 2, 2020 13:07
@yorinasub17
Copy link
Contributor

Thanks! Will merge and release now!

@yorinasub17 yorinasub17 merged commit 0e0fb57 into gruntwork-io:master Jun 2, 2020
@AlainODea AlainODea deleted the ao-tgenv-support branch June 3, 2020 17:28
@oasys oasys mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants