Fix terraform-validate hook #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
reviewed
Jun 14, 2020
hooks/adoclink-check.sh
Outdated
| # workaround to allow GitHub Desktop to work, add this (hopefully harmless) setting here. | ||
| export PATH=$PATH:/usr/local/bin | ||
|
|
||
| if ! command -v asciidoc-link-check; then |
There was a problem hiding this comment.
Doh! This is a WIP script that I did not intend to check in. Removed! 96f2c4f
Comment on lines
+12
to
+13
| terraform init -backend=false | ||
| terraform validate |
There was a problem hiding this comment.
Is dir not necessary because of the pushd above?
There was a problem hiding this comment.
Yup. In fact, dir is a relative path, which is why it is breaking.
|
Thanks for review! I verified this works on one of our repos. Going to merge this in now! |
Closed
1 task
joelbcastillo
pushed a commit
to Hyperfine/pre-commit
that referenced
this pull request
Dec 29, 2021
…gh-sponsors Add link to GitHub Sponsors + Open Collective
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31