Skip to content

Run helmlint hook as single process #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Run helmlint hook as single process #35

merged 1 commit into from
Aug 17, 2020

Conversation

shmileee
Copy link
Contributor

By default pre-commit will execute helmlint in parallel, which due to current logic implemented by helmlint will result in linting same chart(s) multiple times.

Current flow:

pre-commit run --all-files --verbose                                                                                                                 Sat Aug 15 13:25[2/1044]
helmlint.................................................................Passed
- hook id: helmlint
- duration: 0.19s

==> Linting /Users/esolidarity/Projects/blog/helm-charts
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed
==> Linting /Users/esolidarity/Projects/blog/helm-charts
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed
==> Linting /Users/esolidarity/Projects/blog/helm-charts
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

With require_serial: true

pre-commit run --all-files --verbose                                                                                                         524ms  Sat Aug 15 13:25:52 2020
helmlint.................................................................Passed
- hook id: helmlint
- duration: 0.28s

==> Linting /Users/esolidarity/Projects/blog/helm-charts
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

charts directory for reference:

tree helm-charts/                                                                                                                            626ms  Sat Aug 15 13:27:10 2020
helm-charts/
├── Chart.yaml
├── charts
│   └── postgresql-8.0.0.tgz
├── deploy.sh
├── requirements.lock
├── requirements.yaml
├── secrets.yaml
├── templates
│   ├── _helpers.tpl
│   ├── backend-certificate.yaml
│   ├── backend-deployment.yaml
│   ├── backend-ingress.yaml
│   ├── backend-service.yaml
│   └── configmap.yaml
└── values.yaml

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution. Will merge and release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants