Skip to content

Update terraform-fmt to match terraform-validate #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2020
Merged

Update terraform-fmt to match terraform-validate #46

merged 2 commits into from
Dec 10, 2020

Conversation

brikis98
Copy link
Member

@brikis98 brikis98 commented Dec 9, 2020 •
edited
Loading

This PR updates the terraform-fmt hook as follows:

  1. Run with -diff -check so the differences are printed, rather than made on disk.
  2. Instead of exiting on the first error, save the exit codes, and print out all fmt errors before exiting.

These changes are very similar to #45.

@brikis98
Update terraform-fmt to match terraform-validate
5fc3e9d 
This PR updates the `terraform-fmt` hook as follows:

1. Extract all the directories with Terraform code first and run `terraform fmt` once per directory. 
1. Print out the directory where we're running `terraform fmt` to make debugging errors much easier.
1. Instead of exiting on the first error, save the exit codes, and print out all `fmt` errors before exiting.

These changes are very similar to #45.
@brikis98 brikis98 requested a review from yorinasub17 as a code owner December 9, 2020 08:56
@brikis98 brikis98 mentioned this pull request Dec 9, 2020
Merged
davidalger
davidalger reviewed Dec 9, 2020
View reviewed changes
@brikis98
Copy link
Member Author

Seems to work great! PR updated.

@zackproser zackproser self-requested a review December 10, 2020 14:58
zackproser
zackproser approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brikis98
Copy link
Member Author

Thanks for the review! Merging now.

@brikis98 brikis98 merged commit e9250bd into master Dec 10, 2020
@brikis98 brikis98 deleted the brikis98-patch-1 branch December 10, 2020 16:11
@brikis98
Copy link
Member Author

https://github.com/gruntwork-io/pre-commit/releases/tag/v0.1.12

@MGough MGough mentioned this pull request Dec 21, 2020
Open
This was referenced May 21, 2021
Closed
Closed
@ayk33
Copy link

ayk33 commented Jul 9, 2021

What was the reason for adding -check? It was kind of nice having it automatically format the tf code for you instead of someone manually making the changes that need to be made?

@L1ghtn1ng
Copy link

What was the reason for adding -check? It was kind of nice having it automatically format the tf code for you instead of someone manually making the changes that need to be made?

I second this as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidalger davidalger davidalger approved these changes

@zackproser zackproser zackproser approved these changes

@yorinasub17 yorinasub17 Awaiting requested review from yorinasub17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brikis98 @ayk33 @L1ghtn1ng @davidalger @zackproser