Skip to content

Fixes #4127. PopupAutocomplete visible not updating when there are no suggestions #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

Fixes #4127. PopupAutocomplete visible not updating when there are no suggestions #4128

merged 2 commits into from
Jun 9, 2025

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jun 5, 2025

Fixes

Proposed Changes/Todos

  • Changed _popup variable to internal for mor easily control with unit tests

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner June 5, 2025 15:59
tig
tig approved these changes Jun 9, 2025
View reviewed changes
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this View needs to be re-written to use Popover

@tig tig merged commit 2d72425 into gui-cs:v2_develop Jun 9, 2025
11 checks passed
@BDisp BDisp deleted the v2_4127_popupautocomplete-no-suggestions-fix branch June 9, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tig tig tig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PopupAutocomplete visible not updating when there are no suggestions
2 participants
@BDisp @tig