Skip to content

Update versions of lint libraries #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 27, 2022
Merged
Prev Previous commit
Add lint ignore command to fix ci/build error
  • Loading branch information
gollumnima committed Aug 27, 2022
commit ff2a90307e4bf9ab439446cf45d4b96fd8c93f23
1 change: 1 addition & 0 deletions src/components/Editor/CodeEditor/index.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable react-hooks/exhaustive-deps */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think disabling the lint rules makes it more explicit to specify line numbers using eslint-disable-line or eslint-disable-next-line comment.

Reference: Disabling Rules - ESLint

@gollumnima @blurfx Would it be okay could I work on this proposal? 🥺

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@x86chi Yes, and if you found an unintentional empty dependency array, could you please update it instead of using eslint-disable comment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

import React, { useEffect, useMemo, useRef, useCallback, useState } from 'react';
import { createStyles, makeStyles, Theme } from '@material-ui/core/styles';
import { useSelector } from 'react-redux';
Expand Down
1 change: 1 addition & 0 deletions src/components/Editor/DrawingBoard/index.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable react-hooks/exhaustive-deps */
import React, { useEffect, useRef } from 'react';
import { useDispatch, useSelector } from 'react-redux';

Expand Down
1 change: 1 addition & 0 deletions src/components/Editor/Sidebar/ButtonWithColor.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable react-hooks/exhaustive-deps */
import React, { useCallback, useState, MouseEvent } from 'react';
import { useSelector, useDispatch } from 'react-redux';

Expand Down
1 change: 1 addition & 0 deletions src/components/Editor/Sidebar/Settings.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable react-hooks/exhaustive-deps */
import React, { useCallback, useEffect, ChangeEvent } from 'react';
import { ActionCreatorWithPayload } from '@reduxjs/toolkit';
import { useSelector, useDispatch } from 'react-redux';
Expand Down
1 change: 1 addition & 0 deletions src/components/Editor/index.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable react-hooks/exhaustive-deps */
import React, { useEffect } from 'react';
import { useSelector, useDispatch } from 'react-redux';

Expand Down
1 change: 1 addition & 0 deletions src/components/commons/Fade.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable react-hooks/exhaustive-deps */
import React, { useEffect, useRef, ReactNode } from 'react';
import MaterialFade from '@material-ui/core/Fade';

Expand Down