-
Notifications
You must be signed in to change notification settings - Fork 27
Update versions of lint libraries #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6ad7a20
Update version of libraries
gollumnima 4960b1d
Update eslint setting
gollumnima 21d9db0
Modify lint style
gollumnima 1d7ecd2
Fix type error in updated version of TypeScript
gollumnima 09702a8
Wip
gollumnima 434f5bf
Merge remote-tracking branch 'upstream/main' into gollumnima
gollumnima 5a5cc20
Modify lint issue
gollumnima e272514
Undo comments in dom.ts
gollumnima 124fe49
Merge remote-tracking branch 'upstream/main' into gollumnima
gollumnima fa58cae
Update package-lock.json
gollumnima d9dd9ff
Remove the codes for supporting the old browser
gollumnima baf5069
Add lint setting for "react-hooks/exhaustive-deps"
gollumnima ff2a903
Add lint ignore command to fix ci/build error
gollumnima File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Add lint ignore command to fix ci/build error
- Loading branch information
commit ff2a90307e4bf9ab439446cf45d4b96fd8c93f23
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think disabling the lint rules makes it more explicit to specify line numbers using
eslint-disable-line
oreslint-disable-next-line
comment.@gollumnima @blurfx Would it be okay could I work on this proposal? 🥺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@x86chi Yes, and if you found an unintentional empty dependency array, could you please update it instead of using eslint-disable comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!