-
Notifications
You must be signed in to change notification settings - Fork 27
Update package-lock.json #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Delete deprecated lib "node-sass" & Add latest "sass"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
22c5b03
to
c6659c0
Compare
Add fsevents as optionalDependencies for non-mac os
c6659c0
to
ce65147
Compare
Hmm. It might be helpful to use |
Would you like to delete node_modules and package-lock.json, and run |
Using npm ci instead npm install
526d8d3
to
026331c
Compare
|
Great 👍 . Could you resolve the conflict? I think you can just use the new |
8d19005
to
6093b5b
Compare
2174f63
to
4e31d4d
Compare
dff0338
to
ac82878
Compare
npm install -f
ac82878
to
957c1fe
Compare
Co-authored-by: Hackerwins <[email protected]>
Resolve issue comment: yorkie-team/codepair#204 (comment) This duplicate key was created in hackerwins#202 PR
Delete deprecated lib "node-sass" & Add latest "sass"
What this PR does / why we need it
Since
lib-sass
andnode-sass
have been deprecated, they fall back to thedart-sass
.Any background context you want to provide?
I installed 1.53.0, the most recent version that can be found in the dart-sass github repo.
Since I could not find any code used by importing the
node-sass
library, I didn't modify any other code.What are the relevant tickets?
Fixes #196
Checklist