Move to ioredis
#53
Merged
Move to ioredis
#53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoicMahieu
added
feature
Closed
|
Hey Loic, |
Merged
Contributor
Author
|
Hi @klaemo Maybe we could just bump a major version with it ? |
LoicMahieu
force-pushed
the
feature/ioredis
branch
from
da6d373 to
4b54114
Compare
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is mostly for opening discussion about a possible migration to
ioredis. I do not favor one over the other.ioredisseems to be more resilient to connection failure, supports sentinel and some other features.It also have a different behavior compared to
redisand introduce a kind of breaking change: it does not fails on startup if connection fails. Instead it push command into a queue and it will be processed when the connection succeed. I didn't find any option for that.In place of completely to
ioredis, we could consider to just supporting it. At this time, there are small issues of passing anioredisasclientoption ofcatbox-redis.What's your opinion ?