Skip to content

Handle multi-line errors #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2015
Merged

Handle multi-line errors #31

merged 1 commit into from
Jun 16, 2015

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 16, 2015

Previously, if an error message spanned multiple lines, it would cause problems with the stack parser in internals.at(). This commit removes the entire error message before processing the stack. Closes #30

Also some linting fixes.

@cjihrig cjihrig added this to the 1.4.1 milestone Jun 16, 2015
@arb arb added the bug Bug or defect label Jun 16, 2015
arb added a commit that referenced this pull request Jun 16, 2015
Handle multi-line errors
@arb arb merged commit 605728f into hapijs:master Jun 16, 2015
@cjihrig cjihrig deleted the 30 branch June 16, 2015 18:58
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot unassigned arb Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

settings.truncateMessages = false causes issues with deep object comparisons
2 participants