Coverage not working on Windows

[hueniverse]

Replaces hapijs/boom#7

[geek]

Will this be possible with our make requirement?

[hueniverse]

No idea. Does it work manually?

[hueniverse]

We just can't support windows. If someone else wants to fix it, I'm open to a PR.

[paed01]

It seems to be a problem with the paths being messed up in Windows.

But I have a suggestion. If the current working directory is removed from the filename with the path.relative function you could simplify the filter pattern.

// lib/coverage.js #18
exports.instrument = function () {

    var currentDir = process.cwd();
    var pattern = /^((?!node_modules\/|test).).*$/i;

    var origLoader = require.extensions['.js'];
    require.extensions['.js'] = function (localModule, filename) {

        var originalFilename = filename;
        filename = filename.replace(/\\/g, '/');

        var relFilename = Path.relative(currentDir, originalFilename).replace(/\\/g, '/');

        if (!pattern.test(relFilename)) {
            return origLoader(localModule, originalFilename);
        }

        var baseDirPath = Path.dirname(filename).replace(/\\/g, '/') + '/.';

        var instrumented = internals.instrument(filename);
        instrumented = instrumented.replace(/require\s*\(\s*("|')\./g, 'require($1' + baseDirPath);
        localModule._compile(instrumented, originalFilename);
    };
};

It worked for me on Windows. Though I'm not sure how it would impact *ux environments.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.