Fix retrying of passing tests #1000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
approved these changes
Jan 6, 2021
Member
devinivy
left a comment
devinivy
left a comment
There was a problem hiding this comment.
Well, that was a funny bug! Thanks for catching and fixing it.
Contributor
Author
|
Funny, yeah - This is a class of bug that tests likely won't catch. The code appears to run as expected, but is just a bit slow. At least it was simple enough to write a failing test. Though in this case, it was not only slow. Given that the test code would be run after the teardown in |
Contributor
|
This was a great find. Thanks @kanongil. |
Contributor
Author
|
Can you do a patch release? |
Member
|
@kanongil consider it done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any test configured with a
retrymore than 1 will erroneously re-run the test logic until all tries are used.The issue is fixed with this PR.