Default both linting thresholds to 0. #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
maybe add some info in the docs that when linting is enabled it will fail the tests if linting warnings/errors are found |
Contributor
Author
|
Sort of done. |
Contributor
|
hmm that only suggest that when not provided a value it defaults to 0, it should really say that enabling linting will result in enabling those options |
Contributor
Author
|
That's implied by "defaults to". |
Contributor
|
I know but it could be read as 'defaults to 0 if the option is used but no value is specified'. Maybe nitpicking but just my thought |
Contributor
Author
|
We'll see if @geek wants a better wording, it's clear enough for me. |
Contributor
|
👍 |
geek
added a commit
that referenced
this pull request
May 19, 2015
Default both linting thresholds to 0.
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #361.