use stable stringify for better objects diff

[iamdoron]

instead of:

[Marsup]

This won't work with a circular object.

[iamdoron]

what do you mean by 'this won't work'? It should act the same as before (all tests have passed)

[Marsup]

My bad, I thought json-stringify-safe was more clever than it really is.

[iamdoron]

Yes, it just outputs "[Circular]".

[Marsup]

Can't we just do StableStringify(obj, { space: indent, replacer: StringifySafe.getSerialize(serializer) }) ?

[iamdoron]

yes, we can 👍
I changed it

[arb]

I would maybe recommend "fast-safe-stringify" as an alternative since I think it's the fastest one out that that doesn't crash on circular references.

[iamdoron]

@arb - using @Marsup suggestion, it is better to use StringifySafe.getSerialize(), as it can be composed with StableStringify seamlessly. There's no such interface in fast-safe-stringify

[geek]

@iamdoron well done, this will be a nice improvement for our console reporter.

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.