Add --bail support #671
Merged
Add --bail support #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marsup
reviewed
Jan 17, 2017
Contributor
Marsup
left a comment
Marsup
left a comment
There was a problem hiding this comment.
Don't you think it would be better to mark the remaining tests as skipped, as it's kind of what happened. I also imagine it would be better handled this way if we get multiple failures on tests ran in parallel.
cjihrig
approved these changes
Jan 17, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM. No real preference on terminating early or skipping remaining tests.
Member
Author
|
@Marsup thanks for the feedback, the PR is updated. |
Contributor
|
Looks even simpler 👍 |
Marsup
approved these changes
Jan 18, 2017
|
Great. Now can someone please do a release so I can use this? :) |
Member
Author
|
@lerouxb published! |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #214